Ticket #1024 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

PageBlock with tableless rendering and no cell width is broken

Reported by: ogrisel Owned by: jmorliaguet
Priority: P2 Milestone: CPS 3.4.0
Component: CPSSkins Version: TRUNK
Severity: major Keywords:


On a tableless theme page, PageBlock?'s cells with no width are rendered as

    <div style="None float: left; overflow-x: hidden"> ... </div>

instead of

    <div style="float: left; overflow-x: hidden"> ... </div>

Which breaks the display in most brothers.

I have tried to change the code as follows but i doesn't seem to work even after exporting my theme with CPSIO, deleting it in the ZMI and reimporting it.

Index: PageBlock.py
--- PageBlock.py        (révision 28393)
+++ PageBlock.py        (copie de travail)
@@ -251,7 +251,9 @@
                 style_tag = []
             if cellsize:
-                style_tag.append(cellsize.getCSSLayoutStyle())
+                css_layout_style = cellsize.getCSSLayoutStyle()
+                if css_layout_style:
+                    style_tag.append(css_layout_style)
             cell_tag.append('style="%s"' % ';'.join(style_tag))
             cellstyle = objects_in_xpos['cellstyler']
             if cellstyle:

Change History

comment:1 Changed 14 years ago by jmorliaguet

  • Status changed from new to assigned

comment:2 Changed 14 years ago by jmorliaguet

  • Status changed from assigned to closed
  • Resolution set to fixed

fixed in [29749]. The inline css code is more concise too.

Note: See TracTickets for help on using tickets.