Ticket #1078 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

Tool method movePortlet is too protected

Reported by: gracinet Owned by: gracinet
Priority: P3 Milestone: CPS 3.4.0
Component: CPSPortlets Version: TRUNK
Severity: trivial Keywords: portlet permission tool
Cc:

Description

One shouldn't require the user to have ManagePortlets? permission if it's about copying a portlet. I had to copy paste this method for my custom needs.

Code extract:

           if 'leave' is set to 1 the source portlet will be left in place.
           Returns: the moved portlet.
        """

        if portlet is None:
            return None

        src_folder = portlet.getLocalFolder()
        if dest_folder is None:
            dest_folder = src_folder

        if dest_slot is None:
            dest_slot = portlet.getSlot()

        if not _checkPermission(ManagePortlets, src_folder) or \
            not _checkPermission(ManagePortlets, dest_folder):
            raise Unauthorized(

Change History

comment:1 Changed 14 years ago by gracinet

  • Priority changed from P1 to P3
  • Version changed from 3.0.0 to TRUNK

comment:2 Changed 14 years ago by gracinet

  • Owner changed from jmorliaguet to gracinet
  • Status changed from new to assigned
  • Milestone changed from unspecified to CPS 3.4.0

comment:3 Changed 14 years ago by gracinet

Fixed [29843]

comment:4 Changed 14 years ago by janguenot

  • Status changed from assigned to closed
  • Resolution set to fixed

Please close the bug when you're fixin them :)

Note: See TracTickets for help on using tickets.