Ticket #1117 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

Invalid psm when accepting a submited document

Reported by: bdelbosc Owned by: janguenot
Priority: P2 Milestone: CPS 3.4.0
Component: CPSDefault Version: 3.3.8
Severity: normal Keywords: psm accepted
Cc:

Description

Invalid psm when accepting a submited document

Looks like [27698] is not correct, when a publisher accept a document he got a "psm_you_must_select_sections_for_publishing" (msgstr: "You must choose at least one section for publication. Publication aborded !") instead of "psm_status_changed".

This is just a wrong message as the document is accepted.

Change History

comment:1 Changed 14 years ago by bdelbosc

  • Priority changed from P1 to P2
  • Milestone changed from CPS 3.2.5 to unspecified

comment:2 Changed 14 years ago by fguillaume

  • Milestone changed from unspecified to CPS 3.4.0

comment:3 Changed 14 years ago by avoinea

Possible solution:

Modified: [........]/content_status_modify.py
==============================================================================
--- [........]/content_status_modify.py	(original)
+++ [........]/content_status_modify.py	Fri Nov 11 03:59:28 2005
@@ -1,5 +1,6 @@
 ##parameters=workflow_action, REQUEST=None, **kw
 # $Id$
+# This file is obsolete in CPS >= 3.3.9
 """
 FIXME: add docstring.
 """
@@ -17,11 +18,6 @@
 
 psm = 'psm_status_changed'
 
-# No section has been specified
-# XXX We should get a list in here
-if REQUEST and len(REQUEST.form) < 3:
-    psm = 'psm_you_must_select_sections_for_publishing'
-
 if workflow_action != 'copy_submit':
     # accept, reject, ...
     if comments:
@@ -36,6 +32,11 @@
                 url += '/'
             url += rpath
 else:
+    # No section has been specified
+    # XXX We should get a list in here
+    if REQUEST and len(REQUEST.form) < 3:
+        psm = 'psm_you_must_select_sections_for_publishing'
+       

comment:4 Changed 14 years ago by ogrisel

I think this is correct. Please check it in. and mark this bug fixed.

comment:5 Changed 14 years ago by avoinea

  • Status changed from new to closed
  • Version changed from 3.3.7 to 3.3.8
  • Resolution set to fixed
  • Milestone changed from CPS 3.4.0 to unspecified

Fixed [29468]

comment:6 Changed 14 years ago by fguillaume

  • Milestone changed from unspecified to CPS 3.4.0

Version is the version in which this bug was observed. Milestone is the one for which the bug is fixed. Don't remove the milestone on closed bugs, they are important.

Note: See TracTickets for help on using tickets.