Ticket #1136 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

The CalZope Calendar does not implement IContainerNamesContainer properly

Reported by: Brian Sutherland <jinty@…> Owned by: lregebro
Priority: P3 Milestone: CPS 3.4.1
Component: CalZope Version: TRUNK
Severity: minor Keywords:
Cc:

Description

The calendar class in Products.CalZope?.zopecal doesn't even make the attempt to implement it's IContainerNamesContainer interface.

Perhaps it would be more correct to override namesAllowed and namesAccepted in the adding view.

=======
--- Products/CalZope/zopecal.py (revision 29474)
+++ Products/CalZope/zopecal.py (working copy)
@@ -196,6 +196,16 @@
 InitializeClass(Attendee)

 class Calendar(SimpleItem, cal.CalendarBase):
+    """A persistent calendar.
+
+    Lets make one and test the interfaces:
+
+        >>> from zope.interface.verify import verifyObject
+        >>> c = Calendar('cal')
+        >>> verifyObject(IContainerNamesContainer, c)
+        True
+    """
+
     security = ClassSecurityInfo()
     implements(IContainerNamesContainer)

Index: Products/CalZope/tests/test_doctest.py
============================================================ =======
--- Products/CalZope/tests/test_doctest.py      (revision 0)
+++ Products/CalZope/tests/test_doctest.py      (revision 0)
@@ -0,0 +1,13 @@
+import unittest
+
+from zope.testing.doctestunit import DocTestSuite
+from Testing.ZopeTestCase import ZopeTestCase, installProdu ct
+
+installProduct('CalCore')
+installProduct('CalZope')
+
+def test_suite():
+    return unittest.TestSuite([
+            DocTestSuite('Products.CalZope.zopecal'),
+            ])
+

Property changes on: Products/CalZope/tests/test_doctest.py
____________________________________________________________ _______
Name: svn:eol-style
   + native

Change History

comment:1 Changed 14 years ago by fguillaume

  • Priority changed from P1 to P3
  • Milestone changed from CPS 3.2.5 to CPS 3.4.0

comment:2 Changed 14 years ago by lregebro

  • Status changed from new to assigned
  • Severity changed from normal to minor
  • Milestone changed from CPS 3.4.0 to CPS 3.4.1

comment:3 Changed 14 years ago by lregebro

  • Status changed from assigned to closed
  • Resolution set to fixed

This was fixed by removing the statement that it implements IContainerNamesContainer. Turns out it's not needed anyway. This was fixed in [32728].

Note: See TracTickets for help on using tickets.