Ticket #1420 (assigned enhancement)

Opened 14 years ago

Last modified 10 years ago

MethodTheme should not require the "Theme" parameter

Reported by: ogrisel Owned by: jmorliaguet
Priority: P1 Milestone: CPS 3.4.10
Component: CPSSkins Version: TRUNK
Severity: normal Keywords:


In the current default theme setup, the front page is associated to the index_html method thanks to the following method theme:

Method Theme Page
index_html Default Front

which makes it impossible to see the front page of another theme such as the autumn theme for instance.

The solution would be to allow methods theme such as:

Method Theme Page
index_html Front

That would take the theme set as default and the 'Front' page is available.

Change History

comment:1 Changed 14 years ago by jmorliaguet

  • Status changed from new to assigned

or the negociation algorithm should be fixed instead.

the 'autumn' theme should ignore the 'index_html' default+front configuration

actually the reason the theme and the page are required in the ZMI is because it should be an AND not an OR.

comment:2 Changed 14 years ago by ogrisel

or the negociation algorithm should be fixed instead. the 'autumn' theme should ignore the 'index_html' default+front configuration

yes, this allows for per theme rules that do not conflict with each other but on the other hand, the method theme selector would no longuer be able to impose different themes for different methods if the 'default' flag is stronger than the method theme in the negociation algorithm.

comment:3 Changed 14 years ago by jmorliaguet

  • Severity changed from major to enhancement

currently the logic is:

if the published object is called 'index_html', then the effective theme and page will be the ones specified (both must be specified).

that's why you can only have one 'index_html' listed.

so instead there should be several 'index_html' with different theme + page combinations, so

one could have:

method theme page 'index_html' 'default' + 'Front' 'index_html' 'autumn' + '...'

and the theme that would have been chosen otherwise (i.e. default theme, cookie, ?theme=...) would be used as a discriminator

I changed to 'enhancement' since the feature works as designed, it's just that there is a use case for which more flexibility is needed.

comment:4 Changed 14 years ago by ebarroca

  • Milestone changed from CPS 3.4.0 to CPS 3.4.1

comment:5 Changed 13 years ago by sfermigier

  • Milestone changed from CPS 3.4.1 to CPS 3.4.2

comment:6 Changed 10 years ago by gracinet

  • Milestone changed from CPS 3.5.0 to CPS 3.4.10

The default theme system in trunk is CPSDesignerThemes now

Note: See TracTickets for help on using tickets.