Ticket #1422 (new enhancement)

Opened 13 years ago

Last modified 13 years ago

factorize portlets

Reported by: tziade Owned by: jmorliaguet
Priority: P2 Milestone: CPS 3.5.7
Component: CPSPortlets Version: TRUNK
Severity: minor Keywords:
Cc: ogrisel@…

Description

factorize redundant portlets over all themes

Change History

comment:1 Changed 13 years ago by tziade

and change names that are unclear:

  • 'content_well' -> 'main_content_top'

comment:2 Changed 13 years ago by atchertchian

I'm not sure it goes in this bug, but:

  • there are some unused slots (?) like 'toptabs'
  • some slots are named 'tree_view' or 'breadcrumb', wouldn't it be clearer to identify some boxes in the page, and name them after their position like 'left', 'top', 'centerbottom', 'centertop', etc...?
  • there are missing slots to ease integration on the curent theme: CPSComment needs to be able to add a portlet beneath the document content to display comments, but no slots have been defined here, for instance.
  • some naming uses should be considered: 'header_sb_user_tabs' is not a good name as i cant guess what it is from this, and using numbers for names is not satisfying neither (welcome, welcome2, welcome3, cpslogo2, etc... should be avoided)

comment:3 Changed 13 years ago by ogrisel

toptabs is not unused, it's used in the themes of the CPSSkins Extension profile (the set of old themes).

Slot renamings should take care of the old themes not to break existing sites.

+1 for the remaining of your comment.

comment:4 Changed 13 years ago by gracinet

+1 for the remaining of content well, because that's the only case where portlets have to live along with non-cpsskins managed rendering (what the current zpt puts there), so we need to have upwards and downwards (and we could have one day the use case of left and right as well) -1 for any other positional renaming. In theory, slots are logical entities. It's up to the web designer to decide what should be displayed where (although I agree it would be weird to put navigation tabs at the bottom of the page).

comment:5 Changed 13 years ago by fguillaume

Why "main_content_top" ? Can't we have a simpler name?

comment:6 Changed 13 years ago by jmorliaguet

when #1413 is fixed there will only be a need for 1 'main_content' slot.

there reason there is main_content_top, main_content_bottom, etc.. is that the content of the main ZPT macro slot stands in the middle.

comment:7 Changed 13 years ago by sfermigier

  • Milestone changed from CPS 3.4.1 to CPS 3.4.2

comment:8 Changed 13 years ago by sfermigier

  • Type changed from defect to enhancement
Note: See TracTickets for help on using tickets.