Ticket #1520 (new defect)

Opened 13 years ago

Last modified 10 years ago

Styles for selected links and box entries are not consistent

Reported by: ogrisel Owned by: jmorliaguet
Priority: P3 Milestone: CPS 3.4.10
Component: CPSSkins Version: TRUNK
Severity: minor Keywords:
Cc:

Description

The CSS that is rendered by a CPSSkins theme does not always treat "li.selected a" and "a:hover" the same way. Here is a proposal to make this more consistent:

Index: skins/CPSSkins/cpsskins_fontshape.dtml
===================================================================
--- skins/CPSSkins/cpsskins_fontshape.dtml      (révision 33836)
+++ skins/CPSSkins/cpsskins_fontshape.dtml      (copie de travail)
@@ -120,6 +120,7 @@
 } </dtml-if>

 <dtml-if A_hover_decoration>
+<dtml-var class> li.selected a,
 <dtml-var class> a:hover,
 <dtml-var class> a:hover div,
 <dtml-var class> a:hover span {
Index: skins/CPSSkins/cpsskins_portalboxshape.dtml
===================================================================
--- skins/CPSSkins/cpsskins_portalboxshape.dtml (révision 33836)
+++ skins/CPSSkins/cpsskins_portalboxshape.dtml (copie de travail)
@@ -44,6 +44,7 @@
 </dtml-if>
 }

+<dtml-var class> .body ul.cpsskinsMenu li a:hover,
 <dtml-var class> .body ul.cpsskinsMenu li.selected a {
 <dtml-if BoxBody_menuin_border_style>
   border-style: <dtml-var BoxBody_menuin_border_style>;
Index: skins/CPSSkins/cpsskins_fontcolor.dtml
===================================================================
--- skins/CPSSkins/cpsskins_fontcolor.dtml      (révision 33836)
+++ skins/CPSSkins/cpsskins_fontcolor.dtml      (copie de travail)
@@ -72,6 +72,7 @@
 } </dtml-if>

 <dtml-if A_hover>
+<dtml-var class> li.selected a,
 <dtml-var class> a:hover,
 <dtml-var class> a:hover div,
 <dtml-var class> a:hover span {
Index: skins/CPSSkins/cpsskins_portalboxcolor.dtml
===================================================================
--- skins/CPSSkins/cpsskins_portalboxcolor.dtml (révision 33836)
+++ skins/CPSSkins/cpsskins_portalboxcolor.dtml (copie de travail)
@@ -2,9 +2,9 @@
           theme_url="base_url + portal_url.getRelativeUrl(getThemeContainer())"
           class="'.boxColor' + title">

-<dtml-var class> .title {
+<dtml-var class> .title {
 <dtml-if BoxTitle_bg_color>
-  background-color: <dtml-var BoxTitle_bg_color>;
+  background-color: <dtml-var BoxTitle_bg_color>;
 </dtml-if>
 <dtml-if BoxTitle_border_color>
   border-color: <dtml-var BoxTitle_border_color>;
@@ -24,11 +24,11 @@
 }

 <dtml-if BoxTitle_font_color>
-<dtml-var class> .title a {
+<dtml-var class> .title a {
   color: <dtml-var BoxTitle_font_color>;
 } </dtml-if>

-<dtml-var class> .body  {
+<dtml-var class> .body  {
 <dtml-if BoxBody_bg_color>
   background-color: <dtml-var BoxBody_bg_color>;
 </dtml-if>
@@ -53,6 +53,7 @@
 </dtml-if>

 <dtml-if BoxBody_menuin_border_color>
+<dtml-var class> .body ul.cpsskinsMenu li a:hover,
 <dtml-var class> .body ul.cpsskinsMenu li.selected a {
   border-color: <dtml-var BoxBody_menuin_border_color>;
 }

JMO: I can check that in if you agree but I do not want to break the look and feel of existing sites thus the RFC.

Change History

comment:1 Changed 13 years ago by sfermigier

  • Milestone changed from CPS 3.4.1 to CPS 3.4.2

Can we apply this patch now ?

comment:2 Changed 10 years ago by gracinet

  • Milestone changed from CPS 3.5.0 to CPS 3.4.10

The default theme system in trunk is CPSDesignerThemes now

Note: See TracTickets for help on using tickets.