Ticket #1530 (closed defect: fixed)

Opened 14 years ago

Last modified 13 years ago

Members doesn't have a 'last_login_time' or 'last_login' property anymore

Reported by: avoinea Owned by: fguillaume
Priority: P2 Milestone: CPS 3.4.5
Component: CPSDefault Version: TRUNK
Severity: normal Keywords:
Cc:

Description

Scratch from logged_in.pt

if first_time and dtool.members.hasEntry(member.getId()):
    mtool.createMemberArea()
    now = context.ZopeTime()
    member.setProperties(last_login_time=now, login_time=now)
  1. Why setting 'last_login_time' and 'login_time' only if first time login ?
  1. 'last_login_time' shouldn't be previous login time ?
  • member.setProperties(last_login_time=now, login_time=now) doesn't change anything.

Change History

comment:1 Changed 14 years ago by fguillaume

Standard CMF behavior is on each login to:

  • set last_login_time to the previous login_time,
  • set login_time to the current time.

comment:2 Changed 14 years ago by ogrisel

beware: I changed that piece of code yesterday in [34693] because of #1560. But this does not fix your problem.

If we are to refactore that behavior we need integration tests to simulate the following use cases :

  • user that is in the members dir with role Member (first login / second login)
  • user that is in the members dir but without the Member role (first login / second login)
  • user that is not in the members dir but that has the Manager role (ie Zope admin)

comment:3 Changed 14 years ago by sfermigier

  • Milestone changed from CPS 3.4.1 to CPS 3.4.2

comment:4 Changed 13 years ago by madarche

  • Status changed from new to closed
  • Priority changed from P1 to P2
  • Version changed from 3.4.0 to TRUNK
  • Resolution set to fixed

Fixed in changeset [51776].

comment:5 Changed 13 years ago by madarche

  • Milestone changed from CPS 3.5.0 to CPS 3.4.5
Note: See TracTickets for help on using tickets.