Ticket #1977 (new defect)

Opened 10 years ago

Last modified 9 years ago

Empty PortalBoxGroup aren't really empty

Reported by: gracinet Owned by: jmorliaguet
Priority: P2 Milestone: CPS 3.4.10
Component: CPSSkins Version: TRUNK
Severity: normal Keywords: portalboxgroup empty
Cc:

Description

PortalBoxGroups? take care of returning an empty string in case the portlets in the slot don't render anything. But the caller of PortalBoxGroup? it self adds one or two surrounding <div> elements. Here's an example of result:

<div style="padding: 10px;">
  <div class="fontColorBlack fontShapeVerdana" style="text-align: left;">
  </div>
</div>

Because of this, and especially because of the padding, it's nearly impossible to achieve the desired outcome: to display as if the PortalBoxGroup wasn't there. Might this behaviour be desireable in some situations (can't think of one) ?

In the macroless mode, the caller is the PageTheme, and it's easy to correct this behaviour. I have local changes to do that.

In the defaut mode however, the PortalBoxGroup is inside a <metal:use-macro> call and I don't know how to omit the surrounding tag.

Change History

comment:1 Changed 10 years ago by gracinet

Sorry, the caller is PageBlock, not PageTheme

comment:2 Changed 9 years ago by gracinet

  • Milestone changed from CPS 3.5.0 to CPS 3.4.10

The default theme system in trunk is CPSDesignerThemes now

Note: See TracTickets for help on using tickets.