Ticket #2149 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Lift dependency on CPSSkins negotiation

Reported by: gracinet Owned by: gracinet
Priority: P2 Milestone: CPS 3.5.1
Component: CPSDesignerThemes Version: TRUNK
Severity: normal Keywords: dependency CPSSkins


The current negotiator shipping with CPSDesignerThemes reuses the theme and page negociation from CPSSkins. This was useful to make the product usable quickly and avoid code duplication in early stages of the project, but now it simply creates confusion.

Just an example: CPSSkins' negotiation takes precedence over the default theme specified in the root container, but has its own notion of default theme. The later is actually about CPSSkins themes. As a consequence, there is no way to declare a theme to be default unless there is also a CPSSkins theme of the same name… Of course, this is not obvious for most current instances, whose default theme is an exported theme.

Another slightly different point (could become another ticket): renderJS gathers javascript needed for portlets. But it does so by introspecting the slots of the CPSSkins theme page. It is still needed in exported profiles. That dependency should be lifted too.

Change History

comment:1 Changed 9 years ago by gracinet

  • Status changed from new to closed
  • Resolution set to fixed

Done in the gracinet-2149` branch, merged and pushed. The method themes have been reimplemented by enhancing the syntax. There's an upgrade step for that.

Check the (new) doc to learn about the new syntax for (local) method themes. Another side effet : the Cherry Picking Negociator is now deprecated.

Note: See TracTickets for help on using tickets.