Ticket #2196 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Error on some preview links

Reported by: gracinet Owned by: gracinet
Priority: P2 Milestone: CPS 3.5.1
Component: CPSDefault Version: 3.5.1rc2
Severity: normal Keywords:
Cc:

Description

For some reasons, it seems to be common to get links to previews that lack the file_html_subfiles parameter, and this ends like this:

  Module Python expression "request['file_html_subfiles']", line 1, in <expression>
  Module AccessControl.ZopeGuards, line 67, in guarded_getitem
  Module ZPublisher.HTTPRequest, line 1221, in __getitem__
KeyError: 'file_html_subfiles'

Just protecting against this absence spares lots of ERROR logs. This bug has certainly be there for a very long time.

Just avoiding to break

Change History

comment:1 Changed 9 years ago by gracinet

Actually it looks as if the culprit where the <base> that does not bear this param. Looks like a few robots like to follow it, too.

Removed the tag alltogether, as it's useless in this case anyway (not even sure if URL query part is admissible, there).

This is pushed.

comment:2 Changed 9 years ago by gracinet

By long time, I mean that I've seen those weird errors since at least 6 month, maybe a year.

comment:3 Changed 9 years ago by gracinet

  • Status changed from new to closed
  • Resolution set to fixed

In use since then. Indeed, less errors.

Note: See TracTickets for help on using tickets.