Ticket #2443 (closed enhancement: fixed)

Opened 8 years ago

Last modified 8 years ago

Remove last remnents of old stylesheets

Reported by: gracinet Owned by: gracinet
Priority: P2 Milestone: CPS 3.5.5
Component: CPSDefault Version: 3.5.2
Severity: normal Keywords:
Cc:

Description

In #2442, the old default.css, and msie.css were removed from CPS' standard <head> fragment. They were referenced back in the theme itself because some styling still depended on them. Namely I saw :

  • styling of the search portlet ;
  • styling of the conformance portlet (w3c validators etc.).

There may be more. Useful rules should go to the main cps-default.css, the default.css and msie.css have to go.

We may consider also separating the stylesheets in one for the page layout (say page.css) and one for the elements (say ergonomy.css)

Change History

comment:1 in reply to: ↑ description Changed 8 years ago by madarche

Replying to gracinet:

[...] We may consider also separating the stylesheets in one for the page layout (say page.css) and one for the elements (say ergonomy.css)

+1

But the word "ergonomy" doesn't exist in English, so the second CSS file could be named after the following ideas: "blocks.css", "components.css", "widgets.css" (maybe, but possibly misleading if those styling apply to some other blocks than pure CPS Widgets).

comment:2 follow-up: ↓ 3 Changed 8 years ago by gracinet

Oh, my !

So let's go for "components.css" or "elements.css", but let's definitely avoid "widgets.css".

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 8 years ago by madarche

Replying to gracinet:

So let's go for "components.css" or "elements.css", but let's definitely avoid "widgets.css".

OK for "components.css". Are the CSS settings introduced for the Byline widget eligible for this file?

That would ease the theme overriding.

comment:4 in reply to: ↑ 3 Changed 8 years ago by madarche

Replying to madarche:

Replying to gracinet:

So let's go for "components.css" or "elements.css", but let's definitely avoid "widgets.css".

OK for "components.css". Are the CSS settings introduced for the Byline widget eligible for this file?

That would ease the theme overriding.

Done splitting cps-default.css into page_layout.css and components.css for both the default and the CPS-3.5 branch.

Last edited 8 years ago by madarche (previous) (diff)

comment:5 Changed 8 years ago by gracinet

  • Status changed from new to closed
  • Resolution set to fixed

Time to close

Note: See TracTickets for help on using tickets.