Ticket #618 (closed defect: fixed)

Opened 15 years ago

Last modified 14 years ago

SQLDirectory (and LDAPBacking ?) doesn't take computed fields into acount

Reported by: dwyart Owned by: trac
Priority: P2 Milestone: CPS 3.4.0
Component: CPSDirectory Version: CPS 3.3 branch
Severity: normal Keywords:

Description (last modified by fguillaume) (diff)

getData in the SQLStorageAdapter calls getFieldIds, which returns all ids, even the ones having read_ignore_storage set.

I propose to define getReadStorageFieldIDs in BaseStorageAdapter?, and call it in SQLStorageAdapter. Is it ok ?

This won't fix the behaviour of searchEntries, which doesn't take into account computed fields (a comment is already there highlighting the problem). This is harder to fix, IMHO, especially if we want to be able to search on computed fields via a 2-pass algo. So the proposed fix is a very partial fix, which make the computed fields only work when not searching.

The code of LDAPStorageAdapter (in LDAPBacking) is working the same way (calling getFieldIds) but I do not know if the call to _getEntryFromLDAP can take computed fields into account. Seems not, but I am not sure.


modif Download (666 bytes) - added by dwyart 15 years ago.
What I did to fix quicky the problem with getData in SQLDirectory

Change History

Changed 15 years ago by dwyart

What I did to fix quicky the problem with getData in SQLDirectory

comment:1 Changed 14 years ago by fguillaume

  • Description modified (diff)
  • Milestone changed from unspecified to CPS 3.4.0

comment:2 Changed 14 years ago by fguillaume

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in [30171] and [30172].

Note: See TracTickets for help on using tickets.